Skip to content

kubelet: enable crio runtime #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rphillips wants to merge 1 commit into from
Closed

kubelet: enable crio runtime #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/ignition/resources/services/kubelet.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ ExecStart=/usr/bin/hyperkube \
--bootstrap-kubeconfig=/etc/kubernetes/kubeconfig \
--kubeconfig=/var/lib/kubelet/kubeconfig \
--rotate-certificates \
--container-runtime=remote \
--container-runtime-endpoint=unix:///var/run/crio/crio.sock \
Copy link
Contributor

@aaronlevy aaronlevy Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also need to align with a change in the pod-checkpointer daemonset: https://github.com/kubernetes-incubator/bootkube/blob/master/cmd/checkpoint/main.go#L21

And if tests pass without this change - I'd be worried (and we should make sure checkpoint tests are actually running.

Copy link
Contributor Author

@rphillips rphillips Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added the command line arg here.

--runtime-request-timeout=10m \
Copy link
Member

@wking wking Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation for this setting is here.

--cni-conf-dir=/etc/kubernetes/cni/net.d \
--cni-bin-dir=/var/lib/cni/bin \
--network-plugin=cni \
Expand Down