OpenStack: clarify doc around computeFlavor property #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that the `computeFlavor` property sets the flavor for both compute and control-plane nodes, unless overridden via the machine-pool `type` property.
openshift-ci-robot
added
size/XS
Member
Author
Member
Author
|
/label platform/openstack |
Member
Author
openshift-ci-robot
requested review from
Fedosin,
maxwelldb and
tomassedovic
maxwelldb
approved these changes
Sep 10, 2019
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, maxwelldb, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
images had a mirror hiccup: probably due to the CI cluster's high CPU load. But trying again anyway: /retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that the
computeFlavorproperty sets the flavor forboth compute and control-plane nodes, unless overridden via the
machine-pool
typeproperty.