Skip to content

use official red hat tooling image #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Sep 11, 2018
Merged

use official red hat tooling image #227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c1b41
use official red hat tooling image
paulfantom Sep 10, 2018
66b01a2
add docker.io prefix
paulfantom Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hack/go-fmt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ else
--env IS_CONTAINER=TRUE \
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \
--workdir /go/src/github.com/openshift/installer \
--entrypoint sh \
quay.io/coreos/golang-testing \
openshift/origin-release:golang-1.10 \
Copy link
Member

@wking wking Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the registry prefix? What if a user is using something based on containers/image (e.g. podman) to pull these and they happen to have neither quay.io nor docker.io in their default search config (docs here and here).

Copy link
Contributor Author

@paulfantom paulfantom Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some strange reason this image isn't present on quay (CC: @smarterclayton @stevekuznetsov).

Copy link
Contributor

@stevekuznetsov stevekuznetsov Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a released image for use by customers, so we do not mirror it to quay.

Copy link
Member

@wking wking Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a released image for use by customers, so we do not mirror it to quay.

So should we have a docker.io/ prefix here?

Copy link
Contributor Author

@paulfantom paulfantom Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

./hack/go-fmt.sh "${@}"
fi
3 changes: 1 addition & 2 deletions hack/go-lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ else
--env IS_CONTAINER=TRUE \
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \
--workdir /go/src/github.com/openshift/installer \
--entrypoint sh \
quay.io/coreos/golang-testing \
openshift/origin-release:golang-1.10 \
./hack/go-lint.sh "${@}"
fi
2 changes: 1 addition & 1 deletion hack/go-vet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ else
--env IS_CONTAINER=TRUE \
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \
--workdir /go/src/github.com/openshift/installer \
quay.io/coreos/golang-testing \
openshift/origin-release:golang-1.10 \
./hack/go-vet.sh "${@}"
fi;