Add libvirt-devel dependency for building
#2219
Conversation
openshift-ci-robot
added
the
size/XS
|
/label platform/baremetal |
On the first stage of the **baremetal** build, the command `go build ...` already requires `libvirt-devel` to be present, otherwise it fails horribly with the following message: ``` Package libvirt was not found in the pkg-config search path. Perhaps you should add the directory containing `libvirt.pc' to the PKG_CONFIG_PATH environment variable No package 'libvirt' found pkg-config: exit status 1 ```
| # It builds an image containing only the openshift-install. | ||
|
|
||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 AS builder | ||
| RUN yum install -y libvirt-devel |
There was a problem hiding this comment.
Current pattern is to chain this up to a trialing yum clean all, like this.
There was a problem hiding this comment.
I don't think anything other than libvirt-devel is needed to compile, we're not actually running the installer or really interacting with libvirt, so the rest isn't needed (I think).
There was a problem hiding this comment.
That makes sense, but makes me wonder why the baremetal installer needs to set the libvirt build tag at all?
There was a problem hiding this comment.
We use a libvirt provisioning host to bootstrap the cluster
There was a problem hiding this comment.
To be clear, those full set of packages are needed wherever you would run the installer from, but they’re not needed to build it
There was a problem hiding this comment.
Can we include them here then? That way folks who wanted to could run the baremetal installer via a container runtime, vs. extracting just the binary and having it dynamically link to local libraries.
There was a problem hiding this comment.
That'd be a little awkward since it'd be so different from how the installer runs elsewhere. It's not a big deal to depend on libvirt. We're only supporting RHEL 8 hosts.
There was a problem hiding this comment.
Also I should mention this is just the build container, we only need devel here. The actual container we're distributing (below this section) has libvirt-libs, so the installer could run inside the container runtime, and talk to an external libvirt.
Having libvirt itself run inside the container would be complicated, we'd need to do many of the things kubervirt does to make that happen.
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1041/ |
|
@thiagoalessio: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam, thiagoalessio The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
IMO |
6 participants
On the first stage of the baremetal build, the command
go build ...already requireslibvirt-develto be present, otherwise it fails horribly with the following message: