Skip to content

Conversation

@ShivanshVij
Copy link

Fix vSphere main.tf file for compatibility with terraform 0.12

Documented in this issue: hashicorp/terraform#19575 , Terraform 0.12 requires having the = symbol in certain places where previous versions did not.

@openshift-ci-robot
Copy link
Contributor

Hi @ShivanshVij. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShivanshVij
To complete the pull request process, please assign dav1x
You can assign the PR to them by writing /assign @dav1x in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

This looks like s duplicate for #2185

@DanyC97
Copy link
Contributor

DanyC97 commented Aug 10, 2019

This looks like s duplicate for #2185

@abhinavdahiya i guess you meant a duplicate of #2057

@abhinavdahiya
Copy link
Contributor

This looks like s duplicate for #2185

@abhinavdahiya i guess you meant a duplicate of #2057

Yes thanks!

/close

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Closed this PR.

Details

In response to this:

This looks like s duplicate for #2185

@abhinavdahiya i guess you meant a duplicate of #2057

Yes thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants