WIP Add Spec3 flag to install config

[vrutkovs]

Replaces #2146

Adds spec3 flag to install-config.yaml which would convert spec2 ignition to spec3.

TODO:

• Verify bootstrap.ign is FCOS-compatible
• Add tests

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[toddnni]

This needs to be val == true.

Context, had a try to run OKD4 on FCOS today. Had to fix this, but next bump will be "failed to unmarshal bootstrap.ign: json: cannot unmarshal object into Go struct field File.append of type bool" as it tries to reread the config at some point and uses the old v2_2 config as template. There doesn't seem to be easy fix for that.

[vrutkovs]

Right, the installer would still use v2 ignition when creating new S3 buckets via terraform.

It doesn't look like installer can support both spec2 and spec3

[openshift-ci-robot]

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	13f26cb	link	/test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7	13f26cb	link	/test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-disruptive	13f26cb	link	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abhinavdahiya]

/close

closing without prejudice due to age. Please consider opening an issue or enhancement to discuss and bring consensus on the fix, or if you think this is still important in current state feel free to reopen.

[openshift-ci-robot]

@abhinavdahiya: Closed this PR.

Details

In response to this:

/close

closing without prejudice due to age. Please consider opening an issue or enhancement to discuss and bring consensus on the fix, or if you think this is still important in current state feel free to reopen.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.