Skip to content

OpenStack: change provider API #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Aug 7, 2019
Merged

OpenStack: change provider API #2144

openshift-merge-robot merged 2 commits into from
Aug 7, 2019

Conversation

@Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 2, 2019

This patch changes OpenStack provider API from openstackproviderconfig.k8s.io/v1alpha1
to openstackproviderconfig.openshift.io/v1alpha1

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2019
@Fedosin Fedosin force-pushed the openshift_machine_api branch from d6e016f to 8a833d3 Compare August 2, 2019 15:02
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@Fedosin Fedosin mentioned this pull request Aug 5, 2019
Closed
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

/retest

@Fedosin Fedosin force-pushed the openshift_machine_api branch from 8a833d3 to ea1e9fa Compare August 5, 2019 13:21
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@Fedosin Fedosin force-pushed the openshift_machine_api branch from ea1e9fa to a78c74b Compare August 5, 2019 13:49
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2019
@ingvagabund
Copy link
Member

ingvagabund commented Aug 5, 2019

Error creating S3 bucket: TooManyBuckets: You have attempted to create more buckets than allowed for e2e-aws-upgrade.

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

yeah, the error is common. I hope it will be fixed soon.

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

/test e2e-aws

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

/test e2e-aws-upgrade

@mrunalp
Copy link
Member

mrunalp commented Aug 5, 2019

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2019

/retest

abhinavdahiya
abhinavdahiya reviewed Aug 6, 2019
View reviewed changes
....k8s.io/cluster-api-provider-openstack/pkg/apis/openstackproviderconfig/v1alpha1/register.go Outdated
Copy link
Contributor

@abhinavdahiya abhinavdahiya Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use this field in the package when creating the provider in https://github.com/openshift/installer/pull/2144/files#diff-a2bd450b1cd3199485e614928c597a91 rather than duplicating it ...

Copy link
Contributor Author

@Fedosin Fedosin Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll propose an update soon.

@Fedosin Fedosin force-pushed the openshift_machine_api branch from a78c74b to 90a7c12 Compare August 6, 2019 19:57
@Fedosin
Change OpenStack provider API
17801eb 
This patch changes OpenStack provider API from openstackproviderconfig.k8s.io/v1alpha1
to openstackproviderconfig.openshift.io/v1alpha1
@Fedosin Fedosin force-pushed the openshift_machine_api branch from 90a7c12 to 17801eb Compare August 6, 2019 20:06
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 6, 2019

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 6, 2019

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 6, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 6, 2019

CI is not feeling well, I'll try to run the tests tomorrow morning.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dd407b0 into openshift:master Aug 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2019

@Fedosin: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 17801eb link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya abhinavdahiya mentioned this pull request Aug 7, 2019
Closed
@Fedosin Fedosin deleted the openshift_machine_api branch November 1, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fedosin @ingvagabund @mrunalp @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-merge-robot