asset/cluster: don't record usernames #2046
Conversation
openshift-ci-robot
added
size/XS
openshift-ci-robot
added
size/S
253126f introduced this so that our telemetry could distinguish between a user, our CI, and other future invokers of the installer. There are privacy concerns around collecting the actual username, so we'll just use "user" instead.
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@crawford: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
253126f introduced this so that our telemetry could distinguish between a user, our CI, and other future invokers of the installer. There are privacy concerns around collecting the actual username, so we'll just use "user" instead. This commit is a clean cherry-pick of c5ff3aa (asset/cluster: don't record usernames, 2019-07-18, openshift#2046).
|
/cherrypick release-4.1 |
|
@sdodson: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.1 and openshift-cherrypick-robot:cherry-pick-2046-to-release-4.1"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
8305685 backports this and the previous PR to release-4.1. Did I forget to PR that? |
|
Ah, #2125 was the backport. |
|
Yeah, I didn't read the discussion through to the end to find it had been added. |
8 participants
253126f introduced this so that our telemetry could distinguish between
a user, our CI, and other future invokers of the installer. There are
privacy concerns around collecting the actual username, so we'll just
use "user" instead.