Add gather support for gcp #2023
Conversation
Include GCP platform in gather command. Add logic to lookup bootstrap and master ip addresses from terraform state file according to the gcp schema.
Error message displays when gather command failed and no ssh keys were passed. The message recommends ensuring ssh keys were in keyring or specifying the key in a flag.
openshift-ci-robot
added
platform/google
size/M
|
/cc @jstuever (resident gather expert) |
|
/assign @jstuever |
|
/test e2e-aws |
|
@abhinavdahiya asked me to look into how the bootstrap node having an ephemeral public ip address could affect the gather command: it should not be an issue. An ephemeral ip is only released if the instance is stopped. If the instance is reset the ip address is maintained. I tested this. Docs:
|
|
Are we concerned a user may stop their instance? If so, we may want to spin off a bug to set a static IP here. |
|
/lgtm I'm with you, the unraveling is a bit clunky and I'd hope there is a cleaner way. But, it works. |
|
/cc @abhinavdahiya for approval |
|
@jstuever: GitHub didn't allow me to request PR reviews from the following users: for, approval. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws |
5 participants
Adds support for the gather command for the GCP platform.
There might be a more elegant way to parse the terraform state file for GCP using the unstructured package, but this implementation works and has error checking at each step.
CORS-1123
/label platform/google