Skip to content

pkg/types/aws: allow specifying AMI ID for machines #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 18, 2019
Merged

pkg/types/aws: allow specifying AMI ID for machines #2002

openshift-merge-robot merged 1 commit into from
Jul 18, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Jul 16, 2019

ref: https://jira.coreos.com/browse/CORS-1103

for aws the new order for osImage is:

  • env OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE
  • platform.aws.amiID
  • embedded ami for the region

/cc @crawford @openshift/openshift-team-installer

@abhinavdahiya
pkg/types/aws: allow specifying AMI ID for machines
fdf94e3 
ref: https://jira.coreos.com/browse/CORS-1103

for aws the new order for osImage is:
- env OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE
- platform.aws.amiID
- embedded ami for the region
@openshift-ci-robot openshift-ci-robot requested review from a team and crawford July 16, 2019 18:18
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2019
@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 16, 2019 •
edited
Loading

looks good to me but I'll give others a chance to take a look

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2019 •
edited
Loading

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 fdf94e3 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor

jstuever commented Jul 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1228a56 into openshift:master Jul 18, 2019
@wking wking mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

Assignees

@jstuever jstuever

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @patrickdillon @openshift-ci-robot @jstuever @openshift-merge-robot