bootstrap: add platform-specific configuration for baremetal #1960
Conversation
openshift-ci-robot
added
the
size/L
stbenjam
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
This commit allows per-platform ignition configuration to be defined. These files should be placed in data/data/bootstrap/<platform>/. Co-authored-by: Steven Hardy <[email protected]>
The baremetal platform (IPI for Bare Metal hosts) includes some additional assets on the bootstrap node for automating some infrastructure requirements that would have normally been handled by some cloud infrastructure service. See data/data/bootstrap/baremetal/README.md for more detailed documentation. Co-authored-by: Ben Nemec <[email protected]> Co-authored-by: Mark McLoughlin <[email protected]> Co-authored-by: Russell Bryant <[email protected]> Co-authored-by: Stephen Benjamin <[email protected]> Co-authored-by: Steven Hardy <[email protected]>
stbenjam
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
stbenjam
changed the title
|
/assign @abhinavdahiya |
|
@abhinavdahiya This now includes much improved documentation. There are still some gaps to address, which we could do in this PR, or as a follow-up, depending on your preference. Thanks! |
|
/approve Had some nits and questions but those are not blocking and can be done as follow-up |
openshift-ci-robot
added
the
approved
|
/retest |
|
Is this PR good to go and we can address the points in the discussion here in follow-ups? Looks like tide is waiting on a lgtm. |
|
/lgtm I approved it to give you guys some time to respond if the fix requests will be done in this pr or follow-up... looks like latter |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
11 participants
This is broken out from #1873. See individual commits for details, but some of the configuration on the bootstrap node should only be enabled for the baremetal platform, so we move these to data/data/bootstrap/baremetal and adjust the code to conditionally read this depending on the platform name.