Skip to content

Conversation

@yifan-gu
Copy link
Contributor

Generate kubeconfig and kubeconfig-kubelet based on tls assets and install config.

Yifan Gu added 3 commits August 29, 2018 14:17
Generate kubeconfig and kubeconfig-kubelet based on tls assets
and install config.

Added a Kubeconfig type to implement asset.Asset interface.

Kubeconfig type generates the admin kubeconfig and the short-lived
kubelet kubeconfig based on tls assets and installconfig.
Add some tests to verify that kubeconfig asset will generate the
expected assets both in-memory and on-disk, also verify that it
will error out when the dependencies are not satisfied in parents.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yifan-gu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@yifan-gu yifan-gu closed this Aug 29, 2018
@yifan-gu yifan-gu deleted the generate_kubeconfig branch August 29, 2018 22:49
@yifan-gu yifan-gu restored the generate_kubeconfig branch August 29, 2018 22:50
@wking
Copy link
Member

wking commented Aug 29, 2018

This is happening in #160 (which is probably why @yifan-gu closed this one).

@openshift-ci-robot
Copy link
Contributor

@yifan-gu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws d0d70ae link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants