upi/vsphere/machine: add missing = for attribute in map

[hexfusion]

terraform v0.12.0+ terraform init will generate error.

$ terraform init
Initializing modules...
There are some problems with the configuration, described below.

The Terraform configuration must be valid before initialization so that
Terraform can determine which modules and providers need to be installed.

Error: Invalid argument name

  on machine/main.tf line 47, in resource "vsphere_virtual_machine" "vm":
  47:       "guestinfo.ignition.config.data"          = "${base64encode(data.ignition_config.ign.*.rendered[count.index])}"

Argument names must not be quoted.

ref: hashicorp/terraform#21402

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hexfusion
To complete the pull request process, please assign staebler
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• upi/vsphere/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/cc @staebler

[hexfusion]

/hold

I think there will be more to this if we want to support terraform 1.12. We should define what version we support and if we are interested in supporting the latest 1.12.x I can upgrade it.

[abhinavdahiya]

I don't think we are planning to support terraform 0.12 for upi templates yet. we should be setting the required version to <=0.11 for templates.

[DanyC97]

I don't think we are planning to support terraform 0.12 for upi templates yet. we should be setting the required version to <=0.11 for templates.

near future plans maybe @abhinavdahiya ? or future future plans ;)

[openshift-ci-robot]

@hexfusion: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	4592f7f	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abhinavdahiya]

I don't think we are planning to support terraform 0.12 for upi templates yet. we should be setting the required version to <=0.11 for templates.

near future plans maybe @abhinavdahiya ? or future future plans ;)

no plans yet, would love contributions. :)

[abhinavdahiya]

/close

[openshift-ci-robot]

@abhinavdahiya: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.