Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Aug 28, 2018

also drops previous work as it confuses people and serves little purpose.

/cc @yifan-gu @wking
/assign @wking @yifan-gu

NOTE: switch on hide whitespaces changes for better visibility.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2018
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Aug 28, 2018

A lot of PRs (ex: this) try to sync previous work of this doc, which was not its purpose. @crawford suggested we don't need this section.

@wking
Copy link
Member

wking commented Aug 28, 2018

Needs a rebase with #188 landed, but otherwise looks good to me :).

also drops previous work as it confuses people and serves little purpose.
@abhinavdahiya
Copy link
Contributor Author

@wking rebased against master. PTAL.

@wking
Copy link
Member

wking commented Aug 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ace9f65 into openshift:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants