Skip to content

Conversation

@yifan-gu
Copy link
Contributor

This PR establishes the initial framework for generating assets using a graph engine (https://jira.coreos.com/browse/CORS-758).

  • Adds an openshift-install binary for generating assets. This is not hooked up to the build process yet. To build the executable, run go build ./cmd/openshift-install.
  • Adds an asset.Store type that generates an asset by walking the tree of dependencies for the asset ensuring that each asset of a dependency has been generated prior to generating the dependent asset.
  • Adds an asset.Stock type that establishes the available assets that can be generated.
  • Adds the install-config asset and its dependent assets (https://jira.coreos.com/browse/CORS-760, https://jira.coreos.com/browse/CORS-759). To generate the install-config asset, run ./openshift-install install-config. The user-provided assets as crude with respect to UX and still need further refinement. The install-config asset does not fully populate the install-config.yml yet.
  • Vendors https://github.com/stretchr/testify to provide some convenience functions for use in unit tests.
  • Vendors https://github.com/pborman/uuid to generate a random UUID for the cluster ID.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 24, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yifan-gu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018
@yifan-gu
Copy link
Contributor Author

Take from #120, and rebased on master, to see if it can pass the tests

@openshift-ci-robot
Copy link
Contributor

@yifan-gu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8fc4566 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifan-gu
Copy link
Contributor Author

Looks like the same thing, so closing and wait for @crawford to have some fix up.

@yifan-gu yifan-gu closed this Aug 24, 2018
@yifan-gu yifan-gu deleted the asset_graph_engine branch August 24, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants