-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create asset graph engine #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- stretchr/testify - pborman/uuid
…tween the stock and assets
…ecific parts of InstallConfig from user input
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Take from #120, and rebased on master, to see if it can pass the tests |
|
@yifan-gu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Looks like the same thing, so closing and wait for @crawford to have some fix up. |
This PR establishes the initial framework for generating assets using a graph engine (https://jira.coreos.com/browse/CORS-758).
go build ./cmd/openshift-install.asset.Storetype that generates an asset by walking the tree of dependencies for the asset ensuring that each asset of a dependency has been generated prior to generating the dependent asset.asset.Stocktype that establishes the available assets that can be generated../openshift-install install-config. The user-provided assets as crude with respect to UX and still need further refinement. The install-config asset does not fully populate the install-config.yml yet.