Skip to content

Conversation

@ashcrow
Copy link
Member

@ashcrow ashcrow commented May 8, 2019

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2019
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also hold off on this until beta5 is decided

@ashcrow ashcrow force-pushed the update-rhcos-bootimage-2019-05-08 branch from d1b9caa to f78316b Compare May 8, 2019 14:23
@ashcrow ashcrow changed the title WIP: rhcos: Bump to 410.8.20190508.1 rhcos: Bump to 410.8.20190508.1 May 8, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2019
@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

@yuqi-zhang updated.

Note: We have confirmation from @tbielawa that this is 👍 version.

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the locations are publicly accessible. Also I can confirm that the corresponding machine-os-content has been promoted so we shouldn't see a downgrade.

@ashcrow ashcrow force-pushed the update-rhcos-bootimage-2019-05-08 branch from f78316b to 0869f7d Compare May 8, 2019 14:38
@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

../../coreos/terraform-provider-matchbox/main.go:11:15: cannot use matchbox.Provider (type func() "github.com/poseidon/terraform-provider-matchbox/vendor/github.com/hashicorp/terraform/terraform".ResourceProvider) as type "github.com/coreos/terraform-provider-matchbox/vendor/github.com/hashicorp/terraform/plugin".ProviderFunc in field value

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

Failures are unrelated to this PR.

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

#1730 is the fix for the e2e failures we are seeing

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/retest

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

Upstream issue fix merged.

/retest

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/test e2e-openstack

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

Another OpenStack flake 🙁

/test e2e-openstack

@abhinavdahiya
Copy link
Contributor

Another OpenStack flake slightly_frowning_face

/test e2e-openstack

openstack PR is not blocking. Will let openstack team know.

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/retest

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/test e2e-openstack

Come on OpenStack!

@timlnx
Copy link

timlnx commented May 8, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@timlnx
Copy link

timlnx commented May 8, 2019

/assign @crawford

@abhinavdahiya
Copy link
Contributor

/hold

until #1727 merges that's a beta5 blocker

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/test e2e-openstack

@abhinavdahiya
Copy link
Contributor

/hold cancel
#1727 merged

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow, tbielawa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/retest

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/test e2e-openstack

Same flake

 One of the configured repositories failed (Unknown),
 and yum doesn't have enough cached data to continue. At this point the only
 safe thing yum can do is fail. There are a few ways to work "fix" this:

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/test e2e-openstack

😖

@cgwalters
Copy link
Member

It doesn't look like a flake but a configuration change; see #1733

I think either an admin needs to override the openstack context, or the installer merges that PR (and have it work).

@abhinavdahiya
Copy link
Contributor

It doesn't look like a flake but a configuration change; see #1733

I think either an admin needs to override the openstack context, or the installer merges that PR (and have it work).

like I said before, openstack is known failing currently and is not blocking for merge for now
#1731 (comment)

@cgwalters
Copy link
Member

Like this but I doubt I have perms:
/override e2e-openstack

@openshift-ci-robot
Copy link
Contributor

@cgwalters: cgwalters unauthorized: /override is restricted to repo administrators

Details

In response to this:

Like this but I doubt I have perms:
/override e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member Author

ashcrow commented May 8, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

@ashcrow: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 0869f7d link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7d1959b into openshift:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants