Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented May 7, 2019

This lists all secret names and then annotations for all but the SA token and dockercfg secrets.

Related to https://bugzilla.redhat.com/show_bug.cgi?id=1707096

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2019
@abhinavdahiya abhinavdahiya changed the title gather: collect secret names for failure analysis BUG 1707096: gather: collect secret names for failure analysis May 7, 2019
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@deads2k
Copy link
Contributor Author

deads2k commented May 7, 2019

/retest

Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented May 8, 2019

/hold

This is not a release blocker, while #1727 is. The hold will keep the merge queue clear until #1727 lands.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@wking
Copy link
Member

wking commented May 8, 2019

#1727 has landed.

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@wking
Copy link
Member

wking commented May 9, 2019

e2e-aws-upgrade:

May  8 21:53:40.362: Could not reach HTTP service through a6c482ad171db11e998ba0ac6288c268-241050195.us-east-1.elb.amazonaws.com:80 after 2m0s

That's https://bugzilla.redhat.com/show_bug.cgi?id=1690087

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 4a97f13 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f656fa7 into openshift:master May 9, 2019
@smarterclayton
Copy link
Contributor

As we get closer to release, please ensure code changes have a bug and the bug is associated in the PR title - follow the conventions described in previous emails about how to associate bugs with PRs. The PR title must be Bug XXXX: <description>.

This PR has an extra colon between Bug and the number, causing it to not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants