cmd/openshift-install/create: optionally preserve bootstrap resources

[jeckersb]

Setting the environment variable
OPENSHIFT_INSTALL_KEEP_BOOTSTRAP_RESOURCES will prevent the installer
from removing bootstrap resources after cluster bootstrap is complete.
This is useful in development for inspection and debugging of the
bootstrap node.

[openshift-ci-robot]

Hi @jeckersb. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeckersb
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: staebler

If they are not already assigned, you can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

This is useful in development for inspection and debugging of the bootstrap node.

installer leaves the bootstrap node around when bootstrapping fails so you should be able to debug your error then.

leaving the bootstrap node around after successful bootstrap and moving on is not something the installer plans to support.

the user is free to ctrl-C the installer after it has created the resources to stop installer from doing anything extra, but the installer cannot provide that option as part of API.

/close

[openshift-ci-robot]

@abhinavdahiya: Closed this PR.

Details

In response to this:

This is useful in development for inspection and debugging of the bootstrap node.

installer leaves the bootstrap node around when bootstrapping fails so you should be able to debug your error then.

leaving the bootstrap node around after successful bootstrap and moving on is not something the installer plans to support.

the user is free to ctrl-C the installer after it has created the resources to stop installer from doing anything extra, but the installer cannot provide that option as part of API.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[beekhof]

@abhinavdahiya There are scenarios other than failures where such functionality is useful.

In John's specific case, he is working on a new method for provisioning etcd and this PR will better allow him to make iterative progress towards that goal. Relying on ctrl-C is problematic in terms of repeatability.

@crawford how do you feel about this one?
He can carry it as a local patch but it seems like a capability that might be useful in other contexts.