Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 11, 2019

kube-ca was an old shared CA that we've moved away from. We now have discrete
chains of trust that are individually managed on the cluster.

Depends on a couple kube-apiserver-operator pulls, but now that we use the real load balancer cert, we just have to fix serving for IP address (pull merged and we're verifying the operator again after the images are built) and we'll be ready to do this.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

/retest

@deads2k deads2k changed the title [WIP] tls: remove kube-ca tls: remove kube-ca Apr 12, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2019
@deads2k deads2k force-pushed the stop-signing-names branch from 2f3bb5f to f7fda09 Compare April 12, 2019 14:03
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

/retest

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

/retest

@wking
Copy link
Member

wking commented Apr 12, 2019

e2e-aws:

level=error msg="\t* aws_vpc.new_vpc: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached."

/retest

@wking
Copy link
Member

wking commented Apr 13, 2019

e2e-aws:

level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 13, 2019

My kingdom for bootstrap container logs.

/hold

To sort out Monday

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 15, 2019

needs #1561

deads2k added 2 commits April 19, 2019 15:23
kube-ca was an old shared CA that we've moved away from.  We now have discrete
chains of trust that are individually managed on the cluster.
@deads2k deads2k force-pushed the stop-signing-names branch from f7fda09 to 4835aab Compare April 19, 2019 19:23
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 19, 2019
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 19, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 19, 2019

simple rebase, reapplying tag

@deads2k deads2k removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4909208 into openshift:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants