Skip to content

aws: fix ICMP ACL #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 10, 2019
Merged

aws: fix ICMP ACL #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/data/aws/vpc/sg-master.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ resource "aws_security_group_rule" "master_ingress_icmp" {

protocol = "icmp"
cidr_blocks = ["${data.aws_vpc.cluster_vpc.cidr_block}"]
from_port = 0
to_port = 0
from_port = -1
to_port = -1
Copy link
Member

@wking wking Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs for these have>

... or ICMP type number if protocol is "icmp"...

From the IANA registry, it looks like we'd want to allow 8 (Echo) and 0 (Echo Reply). Do we want to block or allow the other types? Personally, I'm in favor of necking this down to the absolute minimum and then opening back up individual types as we have requests for them (e.g. "we want ping support, and that requires types 0 and 8").

}

resource "aws_security_group_rule" "master_ingress_ssh" {
Expand Down
6 changes: 3 additions & 3 deletions data/data/aws/vpc/sg-worker.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ resource "aws_security_group_rule" "worker_ingress_icmp" {
security_group_id = "${aws_security_group.worker.id}"

protocol = "icmp"
cidr_blocks = ["0.0.0.0/0"]
from_port = 0
to_port = 0
cidr_blocks = ["${data.aws_vpc.cluster_vpc.cidr_block}"]
from_port = -1
to_port = -1
}

resource "aws_security_group_rule" "worker_ingress_ssh" {
Expand Down