Skip to content

Conversation

@eparis
Copy link
Member

@eparis eparis commented Aug 20, 2018

Since we used the variable name in both places terraform tried to run both at
the same time. We could have created an explicit dep, or done this via an
implicit dep. I did implicit.

Fixes: #138

…ing a dns record

Since we used the variable name in both places terraform tried to run both at
the same time. We could have created an explicit dep, or done this via an
implicit dep.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2018
@wking
Copy link
Member

wking commented Aug 20, 2018

This is for #138?

@wking
Copy link
Member

wking commented Aug 20, 2018

The e2e-aws error was:

1 error(s) occurred:

* aws_s3_bucket.tectonic: 1 error(s) occurred:

* aws_s3_bucket.tectonic: Error putting S3 ACL: OperationAborted: A conflicting conditional operation is currently in progress against this resource. Please try again.
	status code: 409, request id: 369D71D8DCE4D4B1, host id: 0QZRoCRLFOXmYmuu0lpj1RCRk08Jlc6XCZc1DMyrIihcLsYtxB0kjrZZ9t/WwZhA+B3v/oEo8zc=

That may be due to an over-reaching removal by my cleanup scripts, which I'm currently running.

@eparis
Copy link
Member Author

eparis commented Aug 20, 2018

Didn't know that existed, but it should. yes. I updated the top comment.

@wking
Copy link
Member

wking commented Aug 20, 2018

/retest

(although without #121 and associated release updates, this libvirt change isn't being exercised by CI).

@jlebon
Copy link
Member

jlebon commented Aug 20, 2018

I can confirm this fixes #138.

@wking
Copy link
Member

wking commented Aug 20, 2018

/lgtm

I'll wait and see if #151 fixes the Ginkgo time out, and if it does I'll kick the tests here again.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2018
@sjenning
Copy link
Contributor

tested and works for me
/retest

@eparis
Copy link
Member Author

eparis commented Aug 23, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 27fb947 into openshift:master Aug 23, 2018
@eparis eparis deleted the libvirt-dns-dep branch August 29, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants