-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create a dependancy between the libvirt network and virsh command adding a dns record #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a dependancy between the libvirt network and virsh command adding a dns record #150
Conversation
…ing a dns record Since we used the variable name in both places terraform tried to run both at the same time. We could have created an explicit dep, or done this via an implicit dep.
|
This is for #138? |
|
The e2e-aws error was: That may be due to an over-reaching removal by my cleanup scripts, which I'm currently running. |
|
Didn't know that existed, but it should. yes. I updated the top comment. |
|
/retest (although without #121 and associated release updates, this libvirt change isn't being exercised by CI). |
|
I can confirm this fixes #138. |
|
/lgtm I'll wait and see if #151 fixes the Ginkgo time out, and if it does I'll kick the tests here again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
tested and works for me |
|
/retest |
Since we used the variable name in both places terraform tried to run both at
the same time. We could have created an explicit dep, or done this via an
implicit dep. I did implicit.
Fixes: #138