Skip to content

Conversation

@serbrech
Copy link
Contributor

See linked issue for details.

fixes #1471

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @serbrech. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2019
@serbrech
Copy link
Contributor Author

@enxebre

@wking
Copy link
Member

wking commented Mar 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serbrech, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019
@wking
Copy link
Member

wking commented Mar 26, 2019

Catching up with 0502c5c (#919).

@wking
Copy link
Member

wking commented Mar 28, 2019

e2e:

level=fatal msg="failed to initialize the cluster: Working towards 0.0.1-2019-03-26-234559: 98% complete: timed out waiting for the condition"

Fixed since by openshift/cluster-version-operator#141.

/retest

@serbrech
Copy link
Contributor Author

Should this be merged now? @wking?

@wking
Copy link
Member

wking commented Apr 3, 2019

e2e-aws:

Failing tests:

[Feature:Builds][Conformance] s2i build with a root user image should create a root build and fail without a privileged SCC [Suite:openshift/conformance/parallel/minimal]

/retest

@openshift-merge-robot openshift-merge-robot merged commit 661a3cf into openshift:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dep check fails in pkg/terraform/exec

4 participants