Skip to content

Conversation

@dav1x
Copy link
Contributor

@dav1x dav1x commented Mar 17, 2019

  1. Added a dynamic external datasource for customizing IP ranges for vSphere clusters. Will check ICMP then return 3 lists of IPs based on the worker/master count.
  2. Removed vsphere guest customizations and added field for guestinfo.coreos.config.data.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dav1x
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wking

If they are not already assigned, you can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2019

@dav1x: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/shellcheck bbb0f9b link /test shellcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson added this to the 4.1 beta 4 milestone Mar 27, 2019
@dav1x
Copy link
Contributor Author

dav1x commented Mar 29, 2019

Closed in favor of #1502

@dav1x dav1x closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants