Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 5, 2019

Through c8b3b55 (#1338).

I've left 8d0847c (#794) undocumented, since it seems like an unstable-enough user-facing API approach that I don't think we want to noise it about and deal with the fall-out when we change the API ;). That commit also made it into this history via 44a9cd3 (#1294).

I've also left off eecf496 (#1294), because I have no idea what that's about ;). I'll fill in an entry for it later once one of the OpenStack devs explains it to me :p. CC @flaper87, @trown

CC @abhinavdahiya, @crawford

Through c8b3b55 (Merge pull request openshift#1338 from
flaper87/sec-groups-update, 2019-05-01).

I've left 8d0847c (openstack: Support setting network UUID via
terraform variable, 2018-12-05, openshift#794) undocumented, since it seems
like an unstable-enough user-facing API approach that I don't think we
want to noise it about and deal with the fall-out when we change the
API ;).  That commit also made it into this history via 44a9cd3
(openshift#1294).

I've also left off eecf496 (openstack: remove neutron dns,
2019-02-19, openshift#1294), because I have no idea what that's about ;).  I'll
fill in an entry for it later once one of the OpenStack devs explains
it to me :p.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@abhinavdahiya
Copy link
Contributor

/approve

@abhinavdahiya
Copy link
Contributor

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 6, 2019
@crawford
Copy link
Contributor

crawford commented Mar 6, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Mar 6, 2019

Tag is up, pulling the hold:

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2a667dc into openshift:master Mar 6, 2019
@wking wking deleted the version-0.14.0 branch March 6, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants