Skip to content

data/aws/master: drop 2 unused outputs #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Feb 28, 2019
Merged

data/aws/master: drop 2 unused outputs #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions data/data/aws/master/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
output "subnet_ids" {
Copy link
Member

@wking wking Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1121 was also in flight removing this (and I'd asked for it to remove cluster_id too). But with it still dangling, I'm happy to land this removal here instead :). @staebler, you'll probably need another rebase once this goes in.

Copy link
Member Author

@eparis eparis Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git will notice it does the same thing and not care that we both have the change.

value = "${var.subnet_ids}"
}

output "cluster_id" {
value = "${var.cluster_id}"
}

output "ip_addresses" {
value = "${aws_instance.master.*.private_ip}"
}