metadata: include openshiftClusterID on AWS #1302
Conversation
openshift-ci-robot
added
size/XS
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
image-registry-operator is using the ID from clusterversion object in the cluster to tag s3 buckets [1].
```
$ AWS_PROFILE=ci aws s3api get-bucket-tagging --bucket image-registry-us-east-1-f23dc729905144e6b844ab3d76a42ed7-a306
{
"TagSet": [
{
"Key": "openshiftClusterID",
"Value": "f23dc729-9051-44e6-b844-ab3d76a42ed7"
},
{
"Key": "expirationDate",
"Value": "2019-02-23T05:39+0000"
}
]
}
```
Therefore the destroy code is leaking registry s3 buckets. Adding the `openshiftClusterID` tag to AWS metadata back to make sure we don't
leak resources.
Installer tried to move to single tag for AWS clusters here [2].
[1]: https://github.com/openshift/cluster-image-registry-operator/blob/7228534c826c92dee38d578445c93f2537f0b775/pkg/storage/s3/s3.go#L288
[2]: openshift#1280
abhinavdahiya
force-pushed
the
fix_aws_destroy
branch
from
d0642f4 to
e6f09ba
Compare
identifier is a list of OR filters. @crawford can you |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhinavdahiya: The following test failed for commit e6f09ba, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
#1298 (comment) seems to have passed after seeing similar error.... |
|
cadvisor appears to be a flake. the rest of e2e passed. We need this to stop the leak and keep CI up. merging. |
|
We also need this for the credentials operator, which is currently using tags like: $ AWS_PROFILE=ci aws iam list-user-tags --user-name ci-op-vsvyv7x0-fd334-openshift-image-registry-ssc87
{
"Tags": [
{
"Value": "bd56b83d-87fd-4119-ac33-2a26ac1ad064",
"Key": "openshiftClusterID"
},
{
"Value": "ci-op-vsvyv7x0-fd334",
"Key": "openshiftClusterName"
},
{
"Value": "owned",
"Key": "kubernetes.io/cluster/bd56b83d-87fd-4119-ac33-2a26ac1ad064"
},
{
"Value": "2019-02-26T12:35+0000",
"Key": "expirationDate"
}
],
"IsTruncated": false
}That's using the cluster ID in the |
6 participants
image-registry-operator is using the ID from clusterversion object in the cluster to tag s3 buckets 1.
Therefore the destroy code is leaking registry s3 buckets. Adding the
openshiftClusterIDtag to AWS metadata back to make sure we don'tleak resources.
Installer tried to move to single tag for AWS clusters here 2.