Skip to content

bootkube.sh: suppress podman output when pulling images #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 24, 2019
Merged

bootkube.sh: suppress podman output when pulling images #1293

openshift-merge-robot merged 1 commit into from
Feb 24, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Feb 22, 2019

Currently the bootkube.sh logs have quite a few of pulling images logs like 1

Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 68cddb23acfe: 0 B / 72.31 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 0 B / 975 B
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 0 B / 471 B
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 0 B / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 0 B / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 0 B / 47.75 KiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 2.97 MiB / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 249.91 KiB / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 4.45 MiB / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 1.67 MiB / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  0s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 7.15 MiB / 7.15 MiB  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 3.73 MiB / 10.15 MiB
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
...
$ podman run --help | rg quiet
   --quiet, -q                                   Suppress output information when pulling images
$ podman pull --help | rg quiet
   --quiet, -q                  Suppress output information when pulling images

using -q flag reduces the noise in the bootkube.sh logs.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2019
@abhinavdahiya
bootkube.sh: suppress podman output when pulling images
9dfdc3c 
Currently the bootkube.sh logs have quite a few of pulling images logs like [1]

```console
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 68cddb23acfe: 0 B / 72.31 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 0 B / 975 B
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 0 B / 471 B
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 0 B / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 0 B / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 0 B / 47.75 KiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 2.97 MiB / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 249.91 KiB / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  0s
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 4.45 MiB / 7.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 1.67 MiB / 10.15 MiB
Feb 21 23:11:36 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  0s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob b1ae8487cc2f: 975 B / 975 B  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 897e36f3fc47: 471 B / 471 B  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 9b3f2521a69b: 7.15 MiB / 7.15 MiB  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob 1214db883504: 3.73 MiB / 10.15 MiB
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: Copying blob f203276ea9f1: 47.75 KiB / 47.75 KiB  1s
Feb 21 23:11:37 ip-10-0-2-183 bootkube.sh[4511]: [52B blob data]
...
```

```console
$ podman run --help | rg quiet
   --quiet, -q                                   Suppress output information when pulling images
$ podman pull --help | rg quiet
   --quiet, -q                  Suppress output information when pulling images
```

using `-q` flag reduces the noise in the bootkube.sh logs.

[1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/471/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/721/artifacts/e2e-aws-op/bootstrap/bootkube.service
@cgwalters
Copy link
Member

cgwalters commented Feb 22, 2019

I feel like this stuff is crying out for a shell function...maybe post 4.0 not being written in shell even 😉

But for now
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member

cgwalters commented Feb 22, 2019

Also will trade this review time for review of the ultra-trivial #1289

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5f736aa into openshift:master Feb 24, 2019
@wking wking mentioned this pull request May 19, 2020
Closed
wking added a commit to wking/openshift-installer that referenced this pull request May 19, 2020
@wking
data/data/bootstrap/files/usr/local/bin/release-image-download: Drop …
0da1087 
…--quiet

We've had the option since 9dfdc3c (bootkube.sh: suppress podman
output when pulling images, 2019-02-21, openshift#1293).  But since d1ec85a
(data/bootstrap: extract ironic images from release image, 2019-08-19, openshift#2234)
that image pull has happened in a separate unit, so output will be in
journals/release-image.log and not cluttering up
journals/bootkube.log.  So get noisy again, to get information like:

  $ podman pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1
  Trying to pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1...Failed
  error pulling image "quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1": unable to pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unable to pull image: Error determining manifest MIME type for docker://quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unexpected http code: 500 (Internal Server Error), URL: https://quay.io/v2/auth?scope=repository%3Aopenshift-release-dev%2Focp-release-nightly%3Apull&service=quay.io

instead of silence like:

  -- Logs begin at Tue 2020-05-19 18:47:10 UTC, end at Tue 2020-05-19 19:12:00 UTC. --
  May 19 18:47:40 ip-10-0-29-43 systemd[1]: Starting Download the OpenShift Release Image...
  May 19 18:47:40 ip-10-0-29-43 release-image-download.sh[1747]: Pulling quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1...
  May 19 18:47:41 ip-10-0-29-43 podman[1749]: 2020-05-19 18:47:41.135323376 +0000 UTC m=+0.318008863 system refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb Awaiting requested review from russellb

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@cgwalters cgwalters

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @cgwalters @openshift-ci-robot @openshift-bot @openshift-merge-robot