types: validate cluster name in InstallConfig #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm |
openshift-ci-robot
added
lgtm
Contributor
Author
|
Updated to add the validation of |
Validate that the cluster name in an InstallConfig is a valid DNS subdomain. Validate that <cluster-name>.<base-domain> is a valid DNS subdomain. The DomainName function in pkg/validate now takes a parameter specifying whether the domain name being validated is permitted to have a trailing dot. The base domain is allowed to have a trailing dot, but the cluster name is not allowed to have a trailing dot. Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1663447
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Apr 4, 2020
This logic became a method in 1ab1cd3 (types: add ClusterDomain helper for InstallConfig, 2019-01-31, openshift#1169); so we can drop the validation-specific helper which was from bf3ee03 (types: validate cluster name in InstallConfig, 2019-02-14, openshift#1255). Or maybe we never needed the validation-specific helper ;).
vrutkovs
pushed a commit
to vrutkovs/installer
that referenced
this pull request
Apr 13, 2020
This logic became a method in 1ab1cd3 (types: add ClusterDomain helper for InstallConfig, 2019-01-31, openshift#1169); so we can drop the validation-specific helper which was from bf3ee03 (types: validate cluster name in InstallConfig, 2019-02-14, openshift#1255). Or maybe we never needed the validation-specific helper ;).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that the cluster name in an InstallConfig is a valid DNS subdomain.
Validate that
<cluster-name>.<base-domain>is a valid DNS subdomain.The DomainName function in pkg/validate now takes a parameter specifying whether the domain name being validated is permitted to have a trailing dot. The base domain is allowed to have a trailing dot, but the cluster name is not allowed to have a trailing dot.
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1663447