openstack: Change MCO port #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
flaper87
force-pushed
the
fix-openstack-again
branch
from
bde5a70 to
5ba1250
Compare
Commit openshift#1180 changed the MCO port from 4900 to 22623, which broke OpenStack deployments as the replace didn't catch 2 places where the port was still hardcoded. In addition, I've decoded the data URL to make the maintenance of this script easier.
flaper87
force-pushed
the
fix-openstack-again
branch
from
5ba1250 to
8a8b59b
Compare
Contributor
|
/assign @tomassedovic |
Contributor
Author
|
/test e2e-aws |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test e2e-aws |
1 similar comment
Contributor
Author
|
/test e2e-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit #1180 changed the MCO port from 4900 to 22623, which broke
OpenStack deployments as the replace didn't catch 2 places where the
port was still hardcoded.
In addition, I've decoded the data URL to make the maintenance of this
script easier.