-
Notifications
You must be signed in to change notification settings - Fork 1.5k
link to ansible role for setting up libvirt dev environment #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link to ansible role for setting up libvirt dev environment #1188
Conversation
|
Previous Ansible tooling for our libvirt setup in #636. My concern is still around portability (e.g. RHEL 7.5 CSB support). From your README, it looks like you are targeting CentOS? Can you call that out in your link (mentioning the version?)? Or are you comfortable fielding issues from folks with RHEL systems? Fedora? Debian? ... |
|
I wasn't aware of that other pull request, so thanks for the link. The role only supports CentOS now but I'd be happy to accept patches if someone wanted to expand that to support other platforms. I can make that clear in the readme for the role. Should I still update the link to say CentOS, or leave it open to avoid having to update it in the future? Either is fine, just let me know what you prefer. |
|
Thanks for this PR. I just set up a machine for the installer with libvirt provider for the first time and the role was quite helpful. |
|
/retest |
|
I'd be happy to move my repo into this org and let the team manage it, if that makes the decision any easier. Functionally I'm not sure there was a huge amount of difference between the 2 implementations, so if you want to stick with the previous implementation that's fine, too. FWIW, I found having it defined as a role made it easier to integrate it with my existing host setup playbook. |
|
From my perspective though this is encouraging doing things the "legacy" way of installing a bunch of stuff on your host. I develop on OpenShift using Fedora Silverblue as a workstation and I don't have |
Add a section to the libvirt howto that points to an ansible role for managing the system configuration steps automatically. Signed-off-by: Doug Hellmann <[email protected]>
a5fa3d2 to
96d7942
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhellmann If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@dhellmann: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a section to the libvirt howto that points to an ansible role for
managing the system configuration steps automatically.
Signed-off-by: Doug Hellmann [email protected]