Skip to content

Conversation

@dhellmann
Copy link
Contributor

Add a section to the libvirt howto that points to an ansible role for
managing the system configuration steps automatically.

Signed-off-by: Doug Hellmann [email protected]

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2019
@wking
Copy link
Member

wking commented Feb 4, 2019

Previous Ansible tooling for our libvirt setup in #636. My concern is still around portability (e.g. RHEL 7.5 CSB support). From your README, it looks like you are targeting CentOS? Can you call that out in your link (mentioning the version?)? Or are you comfortable fielding issues from folks with RHEL systems? Fedora? Debian? ...

@dhellmann
Copy link
Contributor Author

I wasn't aware of that other pull request, so thanks for the link.

The role only supports CentOS now but I'd be happy to accept patches if someone wanted to expand that to support other platforms. I can make that clear in the readme for the role.

Should I still update the link to say CentOS, or leave it open to avoid having to update it in the future? Either is fine, just let me know what you prefer.

@tombarron
Copy link

Thanks for this PR. I just set up a machine for the installer with libvirt provider for the first time and the role was quite helpful.

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 5, 2019

something to keep in mind for openshift-ansible code base @vrutkovs @sdodson ? my 0.02 $ ...

@openshift-bot
Copy link
Contributor

/retest

@sdodson
Copy link
Member

sdodson commented Feb 12, 2019

something to keep in mind for openshift-ansible code base @vrutkovs @sdodson ? my 0.02 $ ...

Yeah, makes sense to converge on whichever of the two implementations (this link, or #636) in both installer and openshift-ansible.

@dhellmann
Copy link
Contributor Author

I'd be happy to move my repo into this org and let the team manage it, if that makes the decision any easier. Functionally I'm not sure there was a huge amount of difference between the 2 implementations, so if you want to stick with the previous implementation that's fine, too. FWIW, I found having it defined as a role made it easier to integrate it with my existing host setup playbook.

@cgwalters
Copy link
Member

From my perspective though this is encouraging doing things the "legacy" way of installing a bunch of stuff on your host. I develop on OpenShift using Fedora Silverblue as a workstation and I don't have libvirt-devel on my host - it lives in my dev container. I live in containers on my desktop the same way we expect our customers to be doing on their servers 😄

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
Add a section to the libvirt howto that points to an ansible role for
managing the system configuration steps automatically.

Signed-off-by: Doug Hellmann <[email protected]>
@dhellmann dhellmann force-pushed the ansible-roles-in-libvirt-readme branch from a5fa3d2 to 96d7942 Compare April 24, 2019 22:26
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhellmann
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wking

If they are not already assigned, you can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@dhellmann: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack a5fa3d20ccd56378840cfbdad30694608857e2f0 link /test e2e-openstack
ci/prow/e2e-libvirt a5fa3d20ccd56378840cfbdad30694608857e2f0 link /test e2e-libvirt
ci/prow/e2e-aws-upgrade 96d7942 link /test e2e-aws-upgrade
ci/prow/e2e-aws 96d7942 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

  1. Also mentioned in libvirt: Update howto and add setup automation. #636, libvirt has proven to be different enough for every dev, that generic guidelines on how to setup make most sense for now.
  2. links to external docs esp non-openshift and private is a no-go.

/close

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Closed this PR.

Details

In response to this:

  1. Also mentioned in libvirt: Update howto and add setup automation. #636, libvirt has proven to be different enough for every dev, that generic guidelines on how to setup make most sense for now.
  2. links to external docs esp non-openshift and private is a no-go.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants