Skip to content

Conversation

@crawford
Copy link
Contributor

@crawford crawford commented Feb 2, 2019

Now that Cincinnati is running in production, the CVO should refer to
that service instead of localhost. This will allow the clusters to check
for updates. Whether or not they can apply them is another story...

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2019
@crawford
Copy link
Contributor Author

crawford commented Feb 2, 2019

/hold

I'll let @smarterclayton lift the hold on this once once he's ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2019
@smarterclayton
Copy link
Contributor

Will double check tonight

Now that Cincinnati is running in production, the CVO should refer to
that service instead of localhost. This will allow the clusters to check
for updates. Whether or not they can apply them is another story...
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2019

@crawford: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 973b8dd link /test e2e-openstack
ci/prow/e2e-libvirt 973b8dd link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

This is fine to merg

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [crawford,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d9f389b into openshift:master Feb 5, 2019
@crawford crawford deleted the cvo branch February 6, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants