A new asset called user-manifests that just picks up user defined manifests #1176
Conversation
…defined manifests A new asset called user-manifest is created so that any files that the user wants to get created can be put in a directory and the installer will end up picking it. The iginition asset will depend on this asset which will have 'empty' files by default, unless something is found on-disk which then gets loaded. It helps us to separate manifests asset and user-defined manifests because there will be no entanglement with other dirty assets and the user can always just plant the manifests without running a separate target 'create manifests' as a sub-step to getting stuff added.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajatchopra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/retest |
|
Closing this in favour of #890 |
|
@rajatchopra: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
A new asset called user-manifest is created so that any files that the user wants to get created
can be put in a directory and the installer will end up picking it.
The iginition asset will depend on this asset which will have 'empty' files by default, unless
something is found on-disk which then gets loaded.
It helps us to separate manifests asset and user-defined manifests because there will be no
entanglement with other dirty assets and the user can always just plant the manifests without
running a separate target 'create manifests' as a sub-step to getting stuff added.