Skip to content

Conversation

@ironcladlou
Copy link
Contributor

Use simpler/more copy-pastable commands for worker node troubleshooting.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2019
@cgwalters
Copy link
Member

Great minds think alike! #1049

@ironcladlou
Copy link
Contributor Author

@cgwalters 😄

@cgwalters
Copy link
Member

cgwalters commented Jan 11, 2019

Yours seems better though a minor bit - I like "topic prefixes" in commit messages (git log docs in this repo shows some of that). Combining yours and mine: docs/troubleshooting: Simplify worker node debugging commands?

@ironcladlou ironcladlou force-pushed the trouble-doc branch 2 times, most recently from a1d1ec8 to c68944d Compare January 11, 2019 15:11
@ironcladlou
Copy link
Contributor Author

@cgwalters

Yours seems better though a minor bit - I like "topic prefixes" in commit messages (git log docs in this repo shows some of that). Combining yours and mine: docs/troubleshooting: Simplify worker node debugging commands?

Good idea... done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the equal sign for consistency with the rest of the doc?

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Jan 11, 2019 via email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text also needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ironcladlou nit: double the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Use simpler/more copy-pastable commands for worker node troubleshooting.
@abhinavdahiya
Copy link
Contributor

/lgtm
/retest

/hold

@crawford doc change only, okay post freeze?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2019
@crawford
Copy link
Contributor

crawford commented Jan 14, 2019

@abhinavdahiya yes, but have me sign off on all of them anyway.

And yes, this one is fine to merge.

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya yes, but have me sign off on all of them anyway.

that's why i added the /hold to get it signed-off 😇

And yes, this one is fine to merge.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit 63bdb7f into openshift:master Jan 14, 2019
wking added a commit to wking/openshift-installer that referenced this pull request Jan 15, 2019
Through 63bdb7f (Merge pull request openshift#1050 from
ironcladlou/trouble-doc, 2019-01-14).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants