-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Simplify worker node troubleshooting steps #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify worker node troubleshooting steps #1050
Conversation
|
Great minds think alike! #1049 |
|
Yours seems better though a minor bit - I like "topic prefixes" in commit messages ( |
a1d1ec8 to
c68944d
Compare
Good idea... done |
docs/user/troubleshooting.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep the equal sign for consistency with the rest of the doc?
c68944d to
bc2ad69
Compare
|
Done
…On Fri, Jan 11, 2019 at 10:53 AM Alex Crawford ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/user/troubleshooting.md
<#1050 (comment)>:
> @@ -11,23 +11,24 @@ The installer doesn't provision worker nodes directly, like it does with master
The status of the Machine API Operator can be checked by running the following command from the machine used to install the cluster:
```sh
-oc --config=${INSTALL_DIR}/auth/kubeconfig --namespace=openshift-cluster-api get pods
+oc --config=${INSTALL_DIR}/auth/kubeconfig --namespace openshift-cluster-api get deployments
Can you keep the equal sign for consistency with the rest of the doc?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1050 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASNO25UxpudrRHOCD_20TXsAKCml-Ejks5vCLOJgaJpZM4Z7mzc>
.
--
Dan Mace
Principal Software Engineer, OpenShift
Red Hat
[email protected]
|
docs/user/troubleshooting.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text also needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
bc2ad69 to
08f0c95
Compare
docs/user/troubleshooting.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ironcladlou nit: double the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed
Use simpler/more copy-pastable commands for worker node troubleshooting.
08f0c95 to
21fd1e9
Compare
|
/lgtm /hold @crawford doc change only, okay post freeze? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhinavdahiya yes, but have me sign off on all of them anyway. And yes, this one is fine to merge. |
that's why i added the
/hold cancel |
Through 63bdb7f (Merge pull request openshift#1050 from ironcladlou/trouble-doc, 2019-01-14).
Use simpler/more copy-pastable commands for worker node troubleshooting.