no-jira: docs: document dual-stack networking support on AWS#10453
no-jira: docs: document dual-stack networking support on AWS#10453tthvo wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
WalkthroughAWS installation documentation is updated to introduce a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/origin#30938 /testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/origin#30938 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/user/aws/customization.md`:
- Around line 134-137: Add a clear TechPreview/non-GA warning to the "Dual-stack
networking (installer-provisioned VPC)" section: insert a short highlighted
notice stating this dual-stack capability is not generally available and may
change, and recommend testing in non-production environments; also add the same
warning to the other dual-stack section referenced around lines 167-170 so both
occurrences explicitly state the feature's non-GA status.
- Around line 49-50: Update the docs to make the dual-stack requirement
consistent with the installer-provisioned dual-stack example by either (A)
narrowing the requirement text to say that "for dual-stack installations where
VPC/subnets already have both IPv4 and IPv6 CIDRs, networking.machineNetwork
must include matching IPv4 and IPv6 CIDRs" or (B) modify the
installer-provisioned dual-stack example (the example under the
installer-provisioned dual-stack section) to include both IPv4 and IPv6 entries
in networking.machineNetwork; ensure references to networking.machineNetwork and
the installer-provisioned dual-stack example are adjusted so the requirement and
example align.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 18a31d68-58a0-4241-806d-a367eb5cbfe1
📒 Files selected for processing (1)
docs/user/aws/customization.md
|
/skip |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/origin#30938 |
|
/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/origin#30952 |
|
/skip |
|
/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/origin#30952 |
|
/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/origin#30952 |
|
/testwith openshift/installer/main/e2e-aws-eusc-techpreview openshift/origin#30954 |
2 participants
Description
Update user guide to document dual-stack networking in AWS. Additionally, this switches the docs to use the new
vpc.subnetsfield instead of the deprecated subnets.Important
AWS dual-stack networking is not yet GA. I just wanted this PR to run some
testwithand get some e2e results.Because
openshift/installer/main/e2e-aws-ovn-dualstack-{ipv4,ipv6}-primary-techpreviewjobs are installer-presubmits, they must include an installer PR or run in the installer repository... Thus, the job will build the installer binary always.../label platform/aws