Prow: Add shellcheck to openshift/installer #104
Conversation
openshift-ci-robot
added
size/S
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejovicu, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| if [ "$IS_CONTAINER" != "" ]; then | ||
| find "${1:-.}" -type f -name '*.sh' -exec shellcheck --format=gcc {} \+ | ||
| else | ||
| docker run -e IS_CONTAINER='TRUE' --rm -v "$(pwd)":/workdir:ro --entrypoint sh quay.io/coreos/shellcheck-alpine:v0.5.0 /workdir/hack/shellcheck.sh /workdir; |
There was a problem hiding this comment.
nit: I think this should use "$(realpath "${DIR}")" instead of "$(pwd)". That way callers could point the containerized check at a specific location if they didn't want to recurse through the whole current working directory. Although with that approach you'd need to either mount this script somewhere else or copy the find command on this line to avoid the script dependency inside the container. Anyway, just ideas for future polishing; nothing to block this PR on.
|
The e2e-aws error was: /retest |
|
/retest |
|
#101 just landed, fixing the yamllint error. /retest |
5 participants
Add shell script to run the shell check task.
This task will be executed by Prow:
openshift/release#1131