Add support for deprovisioning users on AWS. #1031
Conversation
dgoodwin
commented
Jan 9, 2019
dgoodwin
commented
openshift-ci-robot
added
the
size/XXL
pkg/destroy/aws/aws.go
Outdated
There was a problem hiding this comment.
Why bother with these wrapper functions? getIAMClient is more characters than the code it wraps ;). But we also have some existing precedent for these in getEC2Client, so I'm fine either way and can clean these up later.
There was a problem hiding this comment.
Just following the convention that was there but you make a good point. :)
|
/approve This looks reasonable to me, although I expect to tear it to pieces and sew it back together differently once I rebase #1039 on top. Anyone else want to look it over before I |
openshift-ci-robot
added
the
approved
|
Reasonable feedback window has passed ;) /lgtm |
|
Thanks! |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
Upcoming cloud-credential-operator will create users with fine grained permissions for the cluster components that need them. These users will be tagged and need to be cleaned up during deprovisioning.
dgoodwin
force-pushed
the
deprovision-users
branch
from
6246609 to
03a0c05
Compare
|
Green but needs another lgtm @wking , I had to fix some compile errors related to the logrus import rename in the file. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
6 participants
