CORS-4055: migrate Route53 API calls to AWS SDK v2#10265
CORS-4055: migrate Route53 API calls to AWS SDK v2#10265openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4055 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a5f5af0-fc03-11f0-867f-09e93b4dd687-0 |
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
/label platform/aws /cc @barbacbd @yunjiang29 |
tthvo
force-pushed
the
CORS-4055-route53
branch
from
2d3d52e to
dcdd3d7
Compare
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a588710-fc59-11f0-99ed-1e5f7c9cd027-0 |
|
/test golint |
|
/test golint flakes? |
tthvo
force-pushed
the
CORS-4055-route53
branch
from
dcdd3d7 to
64a0786
Compare
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6b3fa80-fc83-11f0-8ca4-51e4c7d2cbe0-0 |
tthvo
force-pushed
the
CORS-4055-route53
branch
from
64a0786 to
f39a9fe
Compare
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96b32720-fd5b-11f0-9d65-0f8c8c4b3605-0 |
openshift-ci
bot
added
the
approved
|
/test artifacts-images |
|
/verified by presubmit and payload testing |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19b181b0-06a5-11f1-9c18-9f7616fe49f5-0 |
|
/jira cc-qa |
|
@gpei: This pull request references CORS-4055 which is a valid jira issue. Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@gpei: This pull request references CORS-4055 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Cool, looks like the command @tthvo Sorry for the noise. I just happened to open this PR and wanted to test if |
|
Oh, no worries at all! This command is pretty cool 😎 |
|
/test okd-scos-images |
Yes, this command can also be used for PRs linked to OCPBUGS issues. I just tried it here - #10296 (comment), and it works, but it seems there's a prerequisite: the issue itself must be a valid issue. |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/05053b70-0962-11f1-8faf-4a4309c5c2e8-0 |
|
/lgtm |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/tide refresh |
|
/test golint |
|
/skip |
|
/test golint |
|
/test shellcheck |
|
/retest-required |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn One test failed, but unrelated to this change |
* CORS-4055: migrate Route53 API calls to AWS SDK v2 The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route53 clients in the pkg/asset and dependent pkg(s). * tests: regenerate asset test mocks * vendor: update vendor
* CORS-4055: migrate Route53 API calls to AWS SDK v2 The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route53 clients in the pkg/asset and dependent pkg(s). * tests: regenerate asset test mocks * vendor: update vendor
6 participants
The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route 53 clients in the pkg/asset and dependent pkg(s).
This PR contains quite a lot refactoring in order to follow the AWS SDK v2 client pattern.