CORS-4142: ensure lbType is NLB when dual-stack is configured #10256
CORS-4142: ensure lbType is NLB when dual-stack is configured #10256openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4142 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label platform/aws |
|
/cc @yunjiang29 |
tthvo
force-pushed
the
CORS-4142-lbType
branch
from
d112c2c to
d1f15d1
Compare
sadasu
left a comment
sadasu
left a comment
There was a problem hiding this comment.
1 Nit inline to explain the default Ingress load balancer values and its new connection to the ipFamily field.
This commit adds validation to ensure platform.aws.lbType is NLB when dual-stack networking is configured on AWS. AWS does not support dual-stack for Classic load balancers. Additionally, if lbType is left empty and ipFamily is set to dual-stack values, the installer will default lbType to NLB.
tthvo
force-pushed
the
CORS-4142-lbType
branch
from
d1f15d1 to
6382d3e
Compare
|
/lgtm |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tthvo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 870432a
into
openshift:main
5 participants
This PR adds validation to ensure
platform.aws.lbTypeisNLBwhen dual-stack networking is configured on AWS. AWS does not support dual-stack for Classic load balancers.Additionally, if
lbTypeis left empty andipFamilyis set to dual-stack values, the installer will defaultlbTypetoNLB. I guess this is a nice user experience so that they have to remember configuring load balancer type.This is part 1 of CORS-4142. Part 2 will focus on populating ingress and
defaultingress-controller manifests.