Skip to content

[release-4.21] OCPBUGS-73878: handle SSH rule deletion for Azure private #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
Open

[release-4.21] OCPBUGS-73878: handle SSH rule deletion for Azure private #10225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/infrastructure/azure/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,15 @@ func (p *Provider) PostDestroy(ctx context.Context, in clusterapi.PostDestroyerI
if err != nil {
return fmt.Errorf("failed to delete security rule: %w", err)
}

}
_, err = networkClientFactory.NewInboundNatRulesClient().Get(
ctx,
resourceGroupName,
in.Metadata.InfraID,
sshRuleName,
nil,
)
if err == nil {
err = deleteInboundNatRule(ctx, &inboundNatRuleInput{
resourceGroupName: resourceGroupName,
loadBalancerName: in.Metadata.InfraID,
Expand All @@ -652,7 +660,6 @@ func (p *Provider) PostDestroy(ctx context.Context, in clusterapi.PostDestroyerI
return fmt.Errorf("failed to delete inbound nat rule: %w", err)
}
}

return nil
}

Expand Down