Skip to content

pkg/asset/installconfig/aws: Use NextMarker for domain pagination #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 8, 2019
Merged

pkg/asset/installconfig/aws: Use NextMarker for domain pagination #1014

openshift-merge-robot merged 1 commit into from
Jan 8, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Jan 8, 2019

Fixing a typo from 390cf77 (#939). Marker is the previous value.

@wking
pkg/asset/installconfig/aws: Use NextMarker for domain pagination
b072210 
Fixing a typo from 390cf77 (pkg/asset/installconfig/aws:
Make base-domain a select widget, 2018-12-18, #939).
Marker is the *previous* value [1].

[1]: https://godoc.org/github.com/aws/aws-sdk-go/service/route53#ListHostedZonesOutput
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@crawford
Copy link
Contributor

crawford commented Jan 8, 2019

Previous failure was:

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.masters.aws_instance.master[2]: 1 error occurred:"
level=error msg="\t* aws_instance.master.2: Error waiting for instance (i-0b3bdc407ba8b5fec) to become ready: Failed to reach target state. Reason: Server.InternalError: Internal error on launch"

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3185615 into master Jan 8, 2019
@wking wking mentioned this pull request Jan 10, 2019
Closed
@wking wking deleted the aws-base-domain-next-marker branch January 10, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

@steveej steveej Awaiting requested review from steveej

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @crawford @openshift-ci-robot @openshift-bot @openshift-merge-robot