hack/build: Pin to RHCOS 47.245 and quay.io/openshift-release-dev/ocp-release:4.0.0-9 #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
force-pushed
the
version-0.9.0-pins
branch
from
eb42169 to
a019730
Compare
…-release:4.0.0-9 That's almost the latest RHCOS release: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json | jq '{latest: .builds[0], timestamp}' { "latest": "47.246", "timestamp": "2019-01-05T23:11:19Z" } I'm going with 47.245, because it's been selected as the likely build for the next OpenShift release. Clayton just pushed 4.0.0-0.alpha-2019-01-04-235315 to quay.io/openshift-release-dev/ocp-release:4.0.0-9. Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing of the pinned release despite openshift/release@60007df2 (Use RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03, openshift/release#1793). Also comment out regions which this particular RHCOS build wasn't pushed to, leaving only: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name' ap-northeast-1 ap-northeast-2 ap-south-1 ap-southeast-1 ap-southeast-2 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-west-3 sa-east-1 us-east-1 us-east-2 us-west-1 us-west-2 I'd initially expected to export the pinning environment variables in release.sh, but I've put them in build.sh here because our continuous integration tests use build.sh directly and don't go through release.sh.
wking
force-pushed
the
version-0.9.0-pins
branch
from
a019730 to
b6ee45c
Compare
crawford
reviewed
Jan 6, 2019
Contributor
crawford
left a comment
crawford
left a comment
There was a problem hiding this comment.
Looks good to me. CI is also green.
Member
Author
|
Tagged as v0.9.0 last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
That's almost the latest RHCOS release:
I'm going with 47.245, because it's been selected as the likely build for the next OpenShift release.
@smarterclayton just pushed 4.0.0-0.alpha-2019-01-04-235315 to quay.io/openshift-release-dev/ocp-release:4.0.0-9.
Renaming
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDEgets us CI testing of the pinned release despite openshift/release@60007df2 (openshift/release#1793).Also comment out regions which this particular RHCOS build wasn't pushed to (like #997), leaving only: