CORS-4188: AWS - Add support to AMD SEV-SNP confidential VMs #10012
Conversation
Update CAPA version to support confidential computing, specifically AMD SEV-SNP, on the AWS platform. The updates include "go get && go mod tidy" in: - top-level - cluster-api/providers/aws Signed-off-by: Fangge Jin <[email protected]>
Run "go mod vendor" in: - top-level - cluster-api/providers/aws Signed-off-by: Fangge Jin <[email protected]>
Signed-off-by: Fangge Jin <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@fangge1212: This pull request references CORS-4188 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Fangge Jin <[email protected]>
Update openshift/api version to support confidential computing, specifically AMD SEV-SNP, on the AWS platform. The updates include "go get && go mod tidy" in top-level. Signed-off-by: Fangge Jin <[email protected]>
Run "go mod vendor" in top level. Signed-off-by: Fangge Jin <[email protected]>
This will allow configuring confidential computing on AWS platform, only AMD SEV-SNP is supported for now. Signed-off-by: Fangge Jin <[email protected]>
fangge1212
force-pushed
the
aws_sev_snp
branch
from
c93872e to
a87b0e5
Compare
client-go depends on api, so it must be updated after bumping api. Signed-off-by: Fangge Jin <[email protected]>
Signed-off-by: Fangge Jin <[email protected]>
NodeSwap has been removed from the openshift API, so remove it from the installer feature gates accordingly. Signed-off-by: Fangge Jin <[email protected]>
fangge1212
force-pushed
the
aws_sev_snp
branch
from
d4990ea to
55c2984
Compare
|
@fangge1212: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
When I tried to bump openshift/client-go to db0dee36 and cluster-api to v1.11.2, I encountered more dependency issues: $ (edit go.mod to remove the replace lines for k83.io/apimachinery and cluster-api) $ go mod tidy |
|
Hi @mtulio @patrickdillon |
The module paths changed in cluster-api v1.11.2. It seems like a big change, so should we bump cluster-api in another PR? |
|
@fangge1212 Bumping cluster-api (capi) to v1.11 is a significant change in the installer as we will need to bump all providers to versions that is compatible with capi v1.11 😞 We have opened a card https://issues.redhat.com/browse/CORS-4262 here to track with more details. |
|
/cc |
3 participants
This PR adds support to AMD SEV-SNP confidential VMs on AWS platform.
Related PRs:
openshift/api: openshift/api#2424
machine-api-operator: openshift/machine-api-operator#1420
machine-api-provider-aws: openshift/machine-api-provider-aws#141
upstream: kubernetes-sigs/cluster-api-provider-aws#5605