Bug 1805919: Insights operator does not require being in an openshift run-level to function #80

openshift-cherrypick-robot · 2020-02-21T17:56:29Z

This is an automated cherry-pick of #78

/assign smarterclayton

Insights should follow normal admission control rules for a cluster.

openshift-ci-robot · 2020-02-21T17:56:30Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] manifests: Remove run-level, insights operator does not need it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-21T17:57:02Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805917, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
expected dependent Bugzilla bug 1805940 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1805917: Remove run-level, insights operator does not need it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-21T17:57:44Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805919, which is invalid:

expected dependent Bugzilla bug 1805917 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1805940 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1805919: Remove run-level, insights operator does not need it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-02-24T10:02:10Z

/lgtm

alexandrevicenzi · 2020-02-24T10:02:17Z

/bugzilla refresh

openshift-ci-robot · 2020-02-24T10:02:22Z

@alexandrevicenzi: This pull request references Bugzilla bug 1805919, which is invalid:

expected dependent Bugzilla bug 1805917 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1805940 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-03-03T10:38:31Z

/bugzilla refresh

openshift-ci-robot · 2020-03-03T10:38:35Z

@alexandrevicenzi: This pull request references Bugzilla bug 1805919, which is invalid:

expected dependent Bugzilla bug 1805917 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1805940 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz · 2020-03-10T15:50:28Z

/lgtm cancel
does not work, after upgrade the label is still present
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_insights-operator/80/pull-ci-openshift-insights-operator-release-4.3-e2e-aws-upgrade/10/artifacts/e2e-aws-upgrade/must-gather/registry-svc-ci-openshift-org-ci-op-qd7y31if-stable-sha256-b9040a77cff97a403fbf6dcb33b18b1aea79b4f5cbd87bedfef49ef729f57e1b/namespaces/openshift-insights/openshift-insights.yaml

related: openshift/library-go#727

CVO uses their own ApplyNamespace for whatever reason so simple bump probably won't do

smarterclayton · 2020-03-13T13:00:19Z

That’s a separate bug. We already need to stop new clusters getting the label.

smarterclayton · 2020-03-13T13:01:06Z

/bugzilla refresh

openshift-ci-robot · 2020-03-13T13:01:14Z

@smarterclayton: This pull request references Bugzilla bug 1805919, which is invalid:

expected dependent Bugzilla bug 1805940 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-03-20T16:04:27Z

/bugzilla refresh

openshift-ci-robot · 2020-03-20T16:04:31Z

@alexandrevicenzi: This pull request references Bugzilla bug 1805919, which is invalid:

expected dependent Bugzilla bug 1805940 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-03-20T16:05:56Z

@smarterclayton can you fix the BZ?

smarterclayton · 2020-03-24T02:04:27Z

/bugzilla refresh

openshift-ci-robot · 2020-03-24T02:04:35Z

@smarterclayton: This pull request references Bugzilla bug 1805919, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1805917 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1805917 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-03-24T12:52:44Z

/lgtm

openshift-ci-robot · 2020-03-24T12:53:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevicenzi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexandrevicenzi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot · 2020-03-24T12:55:59Z

@alexandrevicenzi: once the present PR merges, I will cherry-pick it on top of approve in a new PR and assign it to you.

Details

In response to this:

/cherry-pick approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-03-24T13:01:49Z

@alexandrevicenzi: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-03-24T14:08:27Z

@smarterclayton I guess you need to add cherry-pick label manually.

I tried to use the bot but the command that I added actually asked to create a cherry-pick from this PR. Let me know if there's a way to cancel that or if I just need to wait and close the PR once it's opened.

openshift-ci-robot · 2020-03-25T19:37:00Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1805919 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1805919: Insights operator does not require being in an openshift run-level to function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

manifests: Remove run-level, insights operator does not need it

61847d1

Insights should follow normal admission control rules for a cluster.

openshift-ci-robot assigned smarterclayton Feb 21, 2020

openshift-cherrypick-robot mentioned this pull request Feb 21, 2020

Bug 1805940: Insights operator does not require being in an openshift run-level to function #78

Merged

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2020

smarterclayton changed the title ~~[release-4.3] manifests: Remove run-level, insights operator does not need it~~ Bug 1805917: Remove run-level, insights operator does not need it Feb 21, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020

openshift-ci-robot requested review from iNecas and tisnik February 21, 2020 17:57

smarterclayton changed the title ~~Bug 1805917: Remove run-level, insights operator does not need it~~ Bug 1805919: Remove run-level, insights operator does not need it Feb 21, 2020

smarterclayton changed the title ~~Bug 1805919: Remove run-level, insights operator does not need it~~ Bug 1805919: Insights operator does not require being in an openshift run-level to function Feb 21, 2020

openshift-ci-robot assigned alexandrevicenzi Feb 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020

openshift-ci-robot assigned stlaz Mar 10, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2020

openshift-merge-robot merged commit 98ecaca into openshift:release-4.3 Mar 25, 2020

Bug 1805919: Insights operator does not require being in an openshift run-level to function #80

Bug 1805919: Insights operator does not require being in an openshift run-level to function #80

Uh oh!

Conversation

openshift-cherrypick-robot commented Feb 21, 2020

Uh oh!

openshift-ci-robot commented Feb 21, 2020

Uh oh!

openshift-ci-robot commented Feb 21, 2020

Uh oh!

openshift-ci-robot commented Feb 21, 2020

Uh oh!

alexandrevicenzi commented Feb 24, 2020

Uh oh!

alexandrevicenzi commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

alexandrevicenzi commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

stlaz commented Mar 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smarterclayton commented Mar 13, 2020

Uh oh!

smarterclayton commented Mar 13, 2020

Uh oh!

openshift-ci-robot commented Mar 13, 2020

Uh oh!

alexandrevicenzi commented Mar 20, 2020

Uh oh!

openshift-ci-robot commented Mar 20, 2020

Uh oh!

alexandrevicenzi commented Mar 20, 2020

Uh oh!

smarterclayton commented Mar 24, 2020

Uh oh!

openshift-ci-robot commented Mar 24, 2020

Uh oh!

alexandrevicenzi commented Mar 24, 2020

Uh oh!

openshift-ci-robot commented Mar 24, 2020

Uh oh!

openshift-cherrypick-robot commented Mar 24, 2020

Uh oh!

openshift-cherrypick-robot commented Mar 24, 2020

Uh oh!

alexandrevicenzi commented Mar 24, 2020

Uh oh!

openshift-ci-robot commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stlaz commented Mar 10, 2020 •

edited

Loading