-
Notifications
You must be signed in to change notification settings - Fork 103
[release-4.11] OCPBUGS-1158: manifests/02-namespace: Explicitly clear run-level label #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.11] OCPBUGS-1158: manifests/02-namespace: Explicitly clear run-level label #676
Conversation
The label was dropped back in: $ git --no-pager log -1 --oneline 75f34c7 75f34c7 manifests: Remove run-level, insights operator does not need it That landed between 4.2 and 4.3: $ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests origin/release-4.2:manifests/02-namespace.yaml: openshift.io/run-level: "1" $ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests ...no hits... So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (Fix run-level label to empty string, 2021-07-07, openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-959 has been cloned as Jira Issue OCPBUGS-1158. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-1158, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/override ci/prow/lint |
|
@sdodson: sdodson unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/lint |
|
/test insights-operator-e2e-tests |
|
@tremes: Overrode contexts on behalf of tremes: ci/prow/lint DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
OK ci/prow/insights-operator-e2e-tests failed again. I am overriding. We have to fix the tests for 4.11 |
|
@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1158 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #672
/assign sdodson