Skip to content

chore(manifests): adding insights capability annotations #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Aug 23, 2022
Merged

chore(manifests): adding insights capability annotations #646

openshift-merge-robot merged 3 commits into from
Aug 23, 2022

Conversation

@rluders
Copy link
Contributor

@rluders rluders commented Jun 28, 2022

This PR modifies the manifests by adding the capability annotations to it.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

n/a

Documentation

n/a

Unit Tests

n/a

Privacy

n/a

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-8504

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from iNecas and natiiix June 28, 2022 14:17
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@wking wking mentioned this pull request Jul 7, 2022
Closed
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2022
@rluders rluders mentioned this pull request Jul 12, 2022
Merged
@rluders rluders force-pushed the insights-capability branch from a7d59e0 to 5cc3273 Compare July 12, 2022 12:15
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2022
@rluders rluders marked this pull request as ready for review July 12, 2022 12:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2022
@openshift-ci openshift-ci bot requested review from derekwaynecarr and tremes and removed request for natiiix July 12, 2022 12:16
tremes
tremes reviewed Jul 12, 2022
View reviewed changes
@tremes
Copy link
Contributor

tremes commented Jul 14, 2022

Mianfests update.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@JoaoFula
Copy link
Contributor

JoaoFula commented Jul 14, 2022

/retest

@JoaoFula
Copy link
Contributor

JoaoFula commented Jul 14, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 14, 2022
@rluders
Copy link
Contributor Author

rluders commented Jul 15, 2022

/retest

@xJustin
Copy link
Contributor

xJustin commented Jul 18, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 18, 2022
@sferich888
Copy link

sferich888 commented Jul 22, 2022

/lgtm

@sferich888
Copy link

sferich888 commented Jul 22, 2022

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 22, 2022
@rluders
Copy link
Contributor Author

rluders commented Jul 22, 2022

This PRs needs openshift/api to be merged first, and also, the CVO openshift/api needs to be bumped, otherwise CI is going to fail.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@rluders
Copy link
Contributor Author

rluders commented Aug 3, 2022

/retest

@rluders
Copy link
Contributor Author

rluders commented Aug 8, 2022

@wking I guess that I'll need to update this one to PascalCase as well, right?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@rluders
Copy link
Contributor Author

rluders commented Aug 23, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@rluders
Copy link
Contributor Author

rluders commented Aug 23, 2022

/retest

@tremes
Copy link
Contributor

tremes commented Aug 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022

/retest-required

Remaining retests: 2 against base HEAD a637577 and 8 for PR HEAD 65ba5cd in total

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 11da6c7 into openshift:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tremes tremes tremes left review comments

@iNecas iNecas Awaiting requested review from iNecas

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

+1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tremes tremes

@sferich888 sferich888

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rluders @tremes @JoaoFula @xJustin @sferich888 @openshift-ci-robot @wking @openshift-merge-robot