add egress ips support to anonymizer by Serhii1011010 · Pull Request #446 · openshift/insights-operator

Serhii1011010 · 2021-06-04T18:15:54Z

Sample Archive

No changes

Documentation

No changes

Unit Tests

No changes

Privacy

No new data was collected

Breaking Changes

Not really

References

https://issues.redhat.com/browse/CCXDEV-4864
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

openshift-ci · 2021-06-04T18:17:35Z

@Sergey1011010: This pull request references Bugzilla bug 1968031, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1968031: add egress ips support to anonymizer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Serhii1011010 · 2021-06-04T18:17:59Z

/bugzilla refresh

openshift-ci · 2021-06-04T18:18:07Z

@Sergey1011010: This pull request references Bugzilla bug 1968031, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Serhii1011010 · 2021-06-07T17:02:56Z

/retest

Serhii1011010 · 2021-06-08T08:29:20Z

/retest

rluders · 2021-06-08T11:38:41Z

pkg/anonymization/anonymizer.go

+		return nil, err
+	}
+
+	for _, hostSubnet := range hostSubnets.Items {


I'm pretty sure that the lint will complain about these two for, 'cause it will say that you should use index or pointer.

Check these links:
https://go-critic.github.io/overview#rangeValCopy-ref
https://stackoverflow.com/questions/20185511/range-references-instead-values

tremes · 2021-06-09T12:15:51Z

@Sergey1011010 would it be possible to test it (in our unit tests) please?

Serhii1011010 · 2021-06-10T14:55:13Z

@tremes added the test

Serhii1011010 · 2021-06-10T19:14:44Z

/retest

Serhii1011010 · 2021-06-11T08:16:48Z

/retest

Serhii1011010 · 2021-06-14T08:20:03Z

/retest

openshift-bot · 2021-06-14T08:26:58Z

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

openshift-ci · 2021-06-14T08:28:03Z

@openshift-bot: This pull request references Bugzilla bug 1968031, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes · 2021-06-14T13:57:13Z

pkg/anonymization/anonymizer.go

 // NewAnonymizer creates a new instance of anonymizer with a provided config observer and sensitive data
 func NewAnonymizer(clusterBaseDomain string, networks []string, secretsClient corev1client.SecretInterface) (*Anonymizer, error) {
-	networks = append(networks, "127.0.0.1/8")
+	networks = append(networks, "127.0.0.0/8")


Why this change please? It's not clear to me at the first glance. We need to update also in the package doc - https://github.com/openshift/insights-operator/pull/446/files#diff-9180eb430c735bed4f79b7892293543fe58bd8bc57493f4f823ca84faa073f8eR12

It was a mistake in the original code, not really a problem cuz anonymizations would still work correctly, but /8 means everything after the first byte(127) should be zeros so that it's a valid mask.

Ahh I see. Thx

tremes · 2021-06-15T06:54:07Z

Reviewed & tested. Please remove BZ Id and I also think it would be nice to backport it to 4.8. Thanks!!
/lgtm

openshift-ci · 2021-06-15T06:54:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-06-15T12:30:39Z

@Sergey1011010: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

add egress ips support to anonymizer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Serhii1011010 · 2021-06-15T12:32:08Z

/retest

openshift-ci bot requested review from natiiix and smarterclayton June 4, 2021 18:16

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021

Serhii1011010 changed the title ~~add egress ips support to anonymizer~~ Bug 1968031: add egress ips support to anonymizer Jun 4, 2021

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 4, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 4, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 4, 2021

openshift-ci bot requested a review from psimovec June 4, 2021 18:18

rluders suggested changes Jun 8, 2021

View reviewed changes

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2021

add egress ips to anonymizer

2aec662

Serhii1011010 force-pushed the add-egress-ips-to-anonymizer branch from d720f60 to 2aec662 Compare June 9, 2021 15:42

Serhii Zakharov added 2 commits June 10, 2021 16:51

unit test for cidrs including egress one

8423ddb

calm down linters

4059819

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2021

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 14, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 14, 2021

tremes reviewed Jun 14, 2021

View reviewed changes

fix docs

94fa443

openshift-ci bot assigned tremes Jun 15, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021

Serhii1011010 changed the title ~~Bug 1968031: add egress ips support to anonymizer~~ add egress ips support to anonymizer Jun 15, 2021

openshift-ci bot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 15, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 15, 2021

openshift-merge-robot merged commit a799c17 into openshift:master Jun 15, 2021

Serhii1011010 mentioned this pull request Jun 22, 2021

[release-4.8] Bug 1974877: Add egress ips to anonymizer to 4.8 #462

Merged

4 tasks

Comments

Conversation

Serhii1011010 commented Jun 4, 2021

Categories

Sample Archive

Documentation

Unit Tests

Privacy

Breaking Changes

References

Uh oh!

openshift-ci bot commented Jun 4, 2021

Uh oh!

Serhii1011010 commented Jun 4, 2021

Uh oh!

openshift-ci bot commented Jun 4, 2021

Uh oh!

Serhii1011010 commented Jun 7, 2021

Uh oh!

Serhii1011010 commented Jun 8, 2021

Uh oh!

rluders Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

Serhii1011010 Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

rluders Jun 9, 2021

Choose a reason for hiding this comment

Uh oh!

tremes commented Jun 9, 2021

Uh oh!

Serhii1011010 commented Jun 10, 2021

Uh oh!

Serhii1011010 commented Jun 10, 2021

Uh oh!

Serhii1011010 commented Jun 11, 2021

Uh oh!

Serhii1011010 commented Jun 14, 2021

Uh oh!

openshift-bot commented Jun 14, 2021

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

tremes Jun 14, 2021

Choose a reason for hiding this comment

Uh oh!

Serhii1011010 Jun 14, 2021

Choose a reason for hiding this comment

Uh oh!

tremes Jun 14, 2021

Choose a reason for hiding this comment

Uh oh!

tremes commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

Serhii1011010 commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants