Skip to content

[release-4.4] Bug 1834677: Gather image registry config #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mfojtik wants to merge 15 commits into from
Closed

[release-4.4] Bug 1834677: Gather image registry config #103

mfojtik wants to merge 15 commits into from

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented May 12, 2020 •
edited
Loading

This picks #100 on top of the refactoring changes.

This is needed so the changes from master are still pickable to release-4.4.

/cc @iNecas @martinkunc

martinkunc and others added 15 commits May 11, 2020 19:52
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2020

@mfojtik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2020

@mfojtik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik changed the title [release-4.4] Gather image registry config [release-4.4] Bug 1834677: Gather image registry config May 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2020

@mfojtik: This pull request references Bugzilla bug 1834677, which is invalid:

  • expected dependent Bugzilla bug 1832232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1834677: Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2020
@mfojtik
Copy link
Contributor Author

mfojtik commented May 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2020

@mfojtik: This pull request references Bugzilla bug 1834677, which is invalid:

  • expected dependent Bugzilla bug 1832232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkunc
Copy link
Contributor

martinkunc commented May 12, 2020

I think it should be this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1834629
That is what I created from yours for backport to 4.4

@mfojtik
Copy link
Contributor Author

mfojtik commented May 12, 2020

@martinkunc i accidentally created new one and closed yours as dupe...

@martinkunc
Copy link
Contributor

martinkunc commented May 12, 2020

ok, sorry

@ricardomaraschini ricardomaraschini mentioned this pull request May 12, 2020
Merged
@iNecas
Copy link
Contributor

iNecas commented May 12, 2020

Seems like the test failure is relevant?

@martinkunc
Copy link
Contributor

martinkunc commented May 12, 2020

/test insights-operator-e2e-tests

This was referenced May 18, 2020
Closed
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2020

@mfojtik: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2020
@martinkunc martinkunc mentioned this pull request May 25, 2020
Merged
tisnik
tisnik approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach to generate doc :) Thank you @mfojtik

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinkunc
Copy link
Contributor

martinkunc commented May 28, 2020

@mfojtik Could you please rebase this one once more ? There should be minimal changes I hope. Thank you!

@martinkunc
Copy link
Contributor

martinkunc commented Jun 2, 2020

@mfojtik Can I fork your changes and prepare a new PR to resolve the conflict ?

@martinkunc martinkunc mentioned this pull request Jun 29, 2020
Merged
@martinkunc
Copy link
Contributor

martinkunc commented Jun 29, 2020

This is being superseeded by #131

@sdodson
Copy link
Member

sdodson commented Jul 2, 2020

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 2, 2020

@sdodson: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@tisnik tisnik tisnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @openshift-ci-robot @martinkunc @iNecas @sdodson @tisnik