-
Notifications
You must be signed in to change notification settings - Fork 74
Add automatic platform args in the global scope #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic platform args in the global scope #142
Conversation
|
Hi @grooverdan. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Daniel Black <[email protected]> fix vendor
Signed-off-by: Daniel Black <[email protected]>
|
/ok-to-test |
|
In Docker, this is only supported starting with v18.09 while using BuildKit. The changes here look reasonable to me, @nalind WDYT? |
|
@mrunalp WDYT? |
use openshift/imagebuilder#142 Signed-off-by: Daniel Black <[email protected]>
|
/approve |
|
So this is missing some /lgtm and removing the /size/xxl ❤️ . |
|
/joke |
|
@grooverdan: Why did the man run around his bed? Because he was trying to catch up on his sleep! DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚥 /joke |
|
@grooverdan: Why does Waldo only wear stripes? Because he doesn't want to be spotted. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can you push the vendor github.com/containerd/containerd updates separately? Then I can remove that from the series. That will remove the size/XXL tag enabling this to be merged. |
|
@nalind @mrunalp @RedHatDan PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grooverdan, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
And scrolling back I realize I never LGTM'd. So doing so now. |
Based on https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
By default assumed build platform = target platform as builder doesn't [yet?] gave platform.