Add integration test for cross-mounting blobs#25
Add integration test for cross-mounting blobs#25openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
size/XL
| // dead TCP connections (e.g. closing laptop mid-download) eventually | ||
| // go away. | ||
| type tcpKeepAliveListener struct { | ||
| *net.TCPListener |
There was a problem hiding this comment.
Maybe it makes sense to give it a name?
There was a problem hiding this comment.
No, it is an embedded field on purpose.
|
Hm ... if s := os.Getenv("REGISTRY_HTTP_TLS_MINVERSION"); len(s) > 0 {if s := os.Getenv("REGISTRY_HTTP_TLS_CIPHERSUITES"); len(s) > 0 {There are no such fields in the configuration [1][2]. It's unclear why it was necessary to name these environment variables like that. I think it will be better to move them to our section in the configuration file. I don't mean in this PR. [1] https://docs.docker.com/registry/configuration/#http |
|
/cc @miminar |
dmage
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
dmage
force-pushed
the
integration-tests
branch
from
9fd0f83 to
75a2c09
Compare
dmage
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, legionus The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
includes: - Support authentication using gcp workload identity federation (PR#26) - add application-credential auth support for swift storage driver (openshift#25)
4 participants
/assign @legionus