Skip to content

DEVEXP-515: Leveraging installation pull secrets. #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 17, 2020
Merged

DEVEXP-515: Leveraging installation pull secrets. #226

openshift-merge-robot merged 2 commits into from
Mar 17, 2020

Conversation

@ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Mar 10, 2020 •
edited
Loading

Leveraging cluster installation pull secrets during image pull through.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 10, 2020
@ricardomaraschini ricardomaraschini mentioned this pull request Mar 10, 2020
Closed
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Mar 10, 2020

/retest

@ricardomaraschini
Bump(*) - Vendoring github.com/docker/docker/registry
9817d43 
This commit updates vendored depes while also adds docker/registry
package as we gonna start using NewStaticCredentialStore.
@ricardomaraschini ricardomaraschini changed the title WIP - Static credentials DEVEXP-515: Leveraging installation pull secrets. Mar 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2020
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Mar 11, 2020

/assign @dmage @coreydaley @adambkaplan

@dmage
Copy link
Contributor

dmage commented Mar 11, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@coreydaley
Copy link

coreydaley commented Mar 11, 2020

@ricardomaraschini Is there any testing that could be added to verify this new code or is what we already had sufficient?

@gabemontero
Copy link

gabemontero commented Mar 11, 2020

@ricardomaraschini Is there any testing that could be added to verify this new code or is what we already had sufficient?

FWIW @coreydaley @ricardomaraschini I have a commit for the samples operator that deletes its copying of the install pull secret to the openshift namespace, so as to leverage what this change acoomplishes

I could push that to a branch for @ricardomaraschini to leverage if you all would think it would help here.

adambkaplan
adambkaplan reviewed Mar 16, 2020
View reviewed changes
go.mod
k8s.io/client-go v0.17.0
k8s.io/api v0.17.2
k8s.io/apimachinery v0.17.2
k8s.io/client-go v0.17.1
Copy link
Contributor

@adambkaplan adambkaplan Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardomaraschini why the skew between k8s.io/api and k8s.io/client-go?

Copy link
Contributor Author

@ricardomaraschini ricardomaraschini Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, that was not on purpose but I chosen to left it anyways :-) do you want me to revert?

Copy link
Contributor Author

@ricardomaraschini ricardomaraschini Mar 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has relation with the library-go update:

https://github.com/openshift/library-go/blob/master/go.mod

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Mar 16, 2020

@ricardomaraschini Is there any testing that could be added to verify this new code or is what we already had sufficient?

I have added an unit test for it, PTAL.

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Mar 16, 2020

/retest

dmage
dmage reviewed Mar 17, 2020
View reviewed changes
dmage
dmage reviewed Mar 17, 2020
View reviewed changes
dmage
dmage reviewed Mar 17, 2020
View reviewed changes
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Mar 17, 2020

/retest

@ricardomaraschini
Leverage installation pull secrets on pullthrough.
e4b966d 
Start to use mounted installation pull secrets during image pullthrough,
also removed registryclient package that is now part of library-go.
@dmage
Copy link
Contributor

dmage commented Mar 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 831fa31 into openshift:master Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero gabemontero mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

+1 more reviewer

@dmage dmage dmage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmage dmage

@adambkaplan adambkaplan

@coreydaley coreydaley

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ricardomaraschini @dmage @coreydaley @gabemontero @openshift-ci-robot @adambkaplan @openshift-merge-robot